Ignore useless error message "broken pipe" #30801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/S
wxiaoguang
added
type/bug
skip-changelog
github-actions
bot
added
modifies/api
delvh
approved these changes
May 1, 2024
| if _, err := ctx.Resp.Write(xmlMetadataWithHeader); err != nil { | ||
| log.Error("write bytes failed: %v", err) | ||
| } | ||
| _, _ = ctx.Resp.Write(xmlMetadataWithHeader) |
There was a problem hiding this comment.
Is there no other way to detect this apart from ignoring errors completely?
There was a problem hiding this comment.
The question is: why do you want to do so? What would you like to do when the "Write" fails .......... I do not see any useful case to handle such error.
There was a problem hiding this comment.
I think we can merge it as-is, if there would be any real requirement to see the "errors", we can improve it then
| if _, err := b.Resp.Write(bs); err != nil { | ||
| log.ErrorWithSkip(skip, "plainTextInternal (status=%d): write bytes failed: %v", status, err) | ||
| } | ||
| _, _ = b.Resp.Write(bs) |
GiteaBot
added
lgtm/need 1
silverwind
reviewed
May 1, 2024
silverwind
changed the title
pull-request-size
bot
added
the
size/S
silverwind
approved these changes
May 2, 2024
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
May 3, 2024
GiteaBot
removed
the
reviewed/wait-merge
wxiaoguang
added a commit
that referenced
this pull request
May 3, 2024
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
May 3, 2024
* giteaofficial/main: (30 commits) Improve grep search (go-gitea#30843) Don't only list code-enabled repositories when using repository API (go-gitea#30817) Fix no edit history after editing issue's title and content (go-gitea#30814) Ignore useless error message "broken pipe" (go-gitea#30801) Fix JS error on pull request page (go-gitea#30838) Fix body margin shifting with modals, fix error on project column edit (go-gitea#30831) Improve repo button row layout (go-gitea#30668) refactor: merge ListActionTasks func to action.go file (go-gitea#30811) Prevent automatic OAuth grants for public clients (go-gitea#30790) Catch and handle unallowed file type errors in issue attachment API (go-gitea#30791) Fix incorrect message id for releaes email (go-gitea#30825) Add hover outline to heatmap squares (go-gitea#30828) Remove external API calls in `TestPassword` (go-gitea#30716) Upgrade chi-binding (go-gitea#30826) Improve context popup rendering (go-gitea#30824) Fix activity heat map padding & locale (go-gitea#30823) Fix issue card layout (go-gitea#30800) Fix branch selector UI (go-gitea#30803) Fix rounded border for segment followed by pagination (go-gitea#30809) Skip gzip for some well-known compressed file types (go-gitea#30796) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #30792